[#IC-501] migrated tslint to eslint

.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "ignorePatterns": [
+        "node_modules",
+        "generated",
+        "**/__tests__/*",
+        "**/__mocks__/*",
+        "Dangerfile.*",
+        "*.d.ts"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "extends": [
+        "@pagopa/eslint-config/strong",
+    ],
+    "rules": {
+
+    }
+}

.gitignore

@@ -9,3 +9,7 @@ coverage
 *.pem
 .npmrc
 .DS_Store
+
+# eslint section
+!.eslintrc.js
+.eslintcache

Dangerfile.ts

@@ -1,7 +1,6 @@
 // import custom DangerJS rules
 // see http://danger.systems/js
 // see https://github.com/teamdigitale/danger-plugin-digitalcitizenship/
-// tslint:disable-next-line:prettier
 import checkDangers from 'danger-plugin-digitalcitizenship';
 
 checkDangers();

package.json

@@ -20,11 +20,12 @@
     "hot-reload": "nodemon --legacy-watch --watch ./dist --inspect=0.0.0.0 --nolazy dist/example.js",
     "postversion": "git push && git push --tags",
     "test": "jest -i",
-    "lint": "tslint --project .",
+    "lint": "eslint . -c .eslintrc.js --ext .ts,.tsx",
     "preversion": "auto-changelog  --config .auto-changelog.json --unreleased --commit-limit false --stdout --template preview.hbs",
     "version": "auto-changelog -p --config .auto-changelog.json --unreleased && git add CHANGELOG.md"
   },
   "devDependencies": {
+    "@pagopa/eslint-config": "^1.3.1",
     "@types/express": "4.17.0",
     "@types/jest": "^24.0.13",
     "@types/node": "10.14.1",
@@ -41,8 +42,8 @@
     "auto-changelog": "^2.2.1",
     "danger": "^7.0.0",
     "danger-plugin-digitalcitizenship": "*",
+    "eslint-plugin-prettier": "^3.0.0",
     "express": "4.17.0",
-    "italia-tslint-rules": "*",
     "jest": "^24.8.0",
     "mock-redis-client": "^0.91.13",
     "nock": "^11.7.1",
@@ -52,7 +53,6 @@
     "shx": "^0.3.2",
     "supertest": "^4.0.2",
     "ts-jest": "^24.0.2",
-    "tslint": "^5.1.0",
     "typescript": "^3.7.0"
   },
   "dependencies": {

src/__mocks__/metadata.ts

@@ -2,7 +2,7 @@ import { IDPEntityDescriptor } from "../types/IDPEntityDescriptor";
 
 import { NonEmptyArray } from "fp-ts/lib/NonEmptyArray";
 
-// tslint:disable-next-line: no-submodule-imports
+// eslint-disable-next-line import/no-internal-modules
 import { NonEmptyString } from "@pagopa/ts-commons/lib/strings";
 
 export const mockIdpMetadata: Record<string, IDPEntityDescriptor> = {

src/__mocks__/request.ts

@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// eslint-disable @typescript-eslint/no-explicit-any
 
 /**
  * mockReq

src/__tests__/index.test.ts

@@ -1,4 +1,4 @@
-// tslint:disable-next-line: no-submodule-imports
+// eslint-disable-next-line import/no-internal-modules
 import { ResponsePermanentRedirect } from "@pagopa/ts-commons/lib/responses";
 import * as express from "express";
 import { left, right } from "fp-ts/lib/Either";
@@ -141,7 +141,7 @@ const serviceProviderConfig: IServiceProviderConfig = {
   }
 };
 
-// tslint:disable-next-line: no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const mockRedisClient: RedisClient = (createMockRedis() as any).createClient();
 
 function initMockFetchIDPMetadata(): void {
@@ -174,7 +174,7 @@ describe("io-spid-commons withSpid", () => {
       appConfig,
       samlConfig,
       serviceProviderConfig,
-      // tslint:disable-next-line: object-literal-sort-keys
+      // eslint-disable-next-line sort-keys
       redisClient: mockRedisClient,
       app,
       acs: async () => ResponsePermanentRedirect({ href: "/success?acs" }),
@@ -217,7 +217,7 @@ describe("io-spid-commons withSpid", () => {
       appConfig,
       samlConfig,
       serviceProviderConfig,
-      // tslint:disable-next-line: object-literal-sort-keys
+      // eslint-disable-next-line sort-keys
       redisClient: mockRedisClient,
       app,
       acs: async () => ResponsePermanentRedirect({ href: "/success?acs" }),

src/bin/startup-idps-metadata.ts

@@ -18,34 +18,37 @@ const argv = yargs
     demandOption: false,
     description: "ENV var name containing IDP Metadata URL",
     normalize: true,
+    // eslint-disable-next-line id-blacklist
     string: true
   })
   .option("testenv-metadata-url-env", {
     demandOption: false,
     description: "ENV var name containing TestEnv2 Metadata URL",
     normalize: true,
+    // eslint-disable-next-line id-blacklist
     string: true
   })
   .option("cie-metadata-url-env", {
     demandOption: false,
     description: "ENV var name containing CIE Metadata URL",
     normalize: true,
+    // eslint-disable-next-line id-blacklist
     string: true
   })
   .help().argv;
 
 interface IIDPSMetadataXML {
-  idps?: string;
-  xx_testenv2?: string;
-  xx_servizicie?: string;
+  readonly idps?: string;
+  readonly xx_testenv2?: string;
+  readonly xx_servizicie?: string;
 }
 
-function printIdpsMetadata(
+const printIdpsMetadata = (
   idpsMetadataENV: string | undefined,
   testEnv2MetadataENV: string | undefined,
   cieMetadataENV: string | undefined
-): Promise<IIDPSMetadataXML> {
-  // tslint:disable: no-object-mutation no-any no-empty
+): Promise<IIDPSMetadataXML> => {
+  // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-explicit-any, @typescript-eslint/no-empty-function
   logger.info = (): any => {};
   const maybeIdpsMetadataURL = pipe(
     O.fromNullable(idpsMetadataENV),
@@ -89,16 +92,16 @@ function printIdpsMetadata(
       maybeTestEnvMetadataURL,
       maybeCIEMetadataURL
     ),
-    // tslint:disable-next-line: no-inferred-empty-object-type
+
     T.map(A.reduce({}, (prev, current) => ({ ...prev, ...current })))
   )();
-}
+};
 
 printIdpsMetadata(
   argv["idp-metadata-url-env"],
   argv["testenv-metadata-url-env"],
   argv["cie-metadata-url-env"]
 )
-  // tslint:disable-next-line: no-console
+  // eslint-disable-next-line no-console
   .then(metadata => console.log(JSON.stringify(metadata, null, 2)))
   .catch(() => logger.error("Error fetching IDP metadata"));

src/config.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 export const SPID_IDP_IDENTIFIERS = {
   "https://id.lepida.it/idp/shibboleth": "lepidaid",
   "https://identity.infocert.it": "infocertid",

src/example.ts

@@ -1,40 +1,38 @@
-// tslint:disable-next-line: no-submodule-imports
+import * as fs from "fs";
 import { ResponsePermanentRedirect } from "@pagopa/ts-commons/lib/responses";
 import {
   EmailString,
   FiscalCode,
   NonEmptyString
-  // tslint:disable-next-line: no-submodule-imports
 } from "@pagopa/ts-commons/lib/strings";
 import * as bodyParser from "body-parser";
 import * as express from "express";
 import { pipe } from "fp-ts/lib/function";
 import * as T from "fp-ts/lib/Task";
-import * as fs from "fs";
 import * as t from "io-ts";
 import passport = require("passport");
 import { SamlConfig } from "passport-saml";
 import * as redis from "redis";
-import {
-  AssertionConsumerServiceT,
-  IApplicationConfig,
-  LogoutT,
-  withSpid
-} from ".";
 import { logger } from "./utils/logger";
 import {
   AggregatorType,
   ContactType,
   EntityType,
   IServiceProviderConfig
 } from "./utils/middleware";
+import {
+  AssertionConsumerServiceT,
+  IApplicationConfig,
+  LogoutT,
+  withSpid
+} from ".";
 
 export const SpidUser = t.intersection([
   t.interface({
     // the following values may be set
     // by the calling application:
-    // authnContextClassRef: SpidLevel,
-    // issuer: Issuer
+    // authnContextClassRef -> SpidLevel,
+    // issuer -> Issuer
     getAssertionXml: t.Function
   }),
   t.partial({
@@ -87,10 +85,13 @@ const serviceProviderConfig: IServiceProviderConfig = {
   // this line is commented due to a future refactor that enables spid-saml-check locally
   // spidValidatorUrl: "http://localhost:8080",
   strictResponseValidation: {
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     "http://localhost:8080": true,
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     "https://spid-testenv2:8088": true
   },
 
+  // eslint-disable-next-line sort-keys
   contacts: [
     {
       company: "Sogetto Aggregatore s.r.l",
@@ -147,12 +148,13 @@ proxyApp.get("*", (req, res) => {
 });
 proxyApp.listen(8080);
 
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 const doneCb = (ip: string | null, request: string, response: string) => {
-  // tslint:disable-next-line: no-console
+  // eslint-disable-next-line no-console
   console.log("*************** done", ip);
-  // tslint:disable-next-line: no-console
+  // eslint-disable-next-line no-console
   console.log(request);
-  // tslint:disable-next-line: no-console
+  // eslint-disable-next-line no-console
   console.log(response);
 };
 
@@ -200,5 +202,5 @@ pipe(
     withSpidApp.listen(3000);
   })
 )()
-  // tslint:disable-next-line: no-console
+  // eslint-disable-next-line no-console
   .catch(e => console.error("Application error: ", e));