Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added chore section to PR_TEMPLATE file #120

Merged
merged 1 commit into from
Sep 23, 2022
Merged

added chore section to PR_TEMPLATE file #120

merged 1 commit into from
Sep 23, 2022

Conversation

arcogabbo
Copy link
Contributor

List of Changes

  • added chore section under Types of changes

Motivation and Context

The current PULL_REQUEST_TEMPLATE.md file doesn't have the chore section under Types of changes

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 0e595df

@arcogabbo arcogabbo merged commit c8e888c into master Sep 23, 2022
@arcogabbo arcogabbo deleted the PR-TEMPLATE-edit branch September 23, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balanza balanza balanza approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arcogabbo @pagopa-github-bot @balanza