[#IOPID-1156] Include additional params in doneCb, if any #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gquadrati
requested review from
BurnedMarshal,
gunzip,
francescopersico,
AleDore,
balanza and
arcogabbo
as code owners
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-1156 |
6 tasks
arcogabbo
reviewed
Nov 30, 2023
There was a problem hiding this comment.
good work, however I believe we can get rid of the inference error with this changes. what do you think @gquadrati? unfortunately, Omit type coming from the spread operator still forces us to cast with as T
|
Kudos, SonarCloud Quality Gate passed!
|
|
/azp run |
|
No pipelines are associated with this pull request. |
arcogabbo
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
See commit history
Motivation and Context
This PR enables the possibility to use additional params in done callback too (now it's allowed in acs callback).
How Has This Been Tested?
Unit test, manual tests with io-mock
Types of changes
Checklist: