PN-11527-fe-e-possibile-generare-unapi-key-inserendo-solo-uno-spazio-nel-campo-nome #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJimMoriarty
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
ImJimMoriarty
changed the title
AndreaCimini90
requested changes
Jun 10, 2024
packages/pn-pa-webapp/src/pages/__test__/NewApiKey.page.test.tsx
Outdated
Show resolved
Hide resolved
AndreaCimini90
previously approved these changes
Jun 10, 2024
AndreaCimini90
approved these changes
Jun 17, 2024
AndreaCimini90
deleted the
PN-11527-fe-e-possibile-generare-unapi-key-inserendo-solo-uno-spazio-nel-campo-nome
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request fixes the minimum character validation for the name field in the NewApiKey form. Previously, the form allowed names with less than 3 characters, which is not desirable. With this fix, the form will now correctly validate that the name has at least 3 characters before allowing submission.
List of changes proposed in this pull request
How to test
Start PA and try to create an api key with less than 3 character and see if the error appear.