Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/PN-11564 - Whole page component to manage the empty state #1254

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mflauti
Copy link
Collaborator

@mflauti mflauti commented Jun 12, 2024

Short description

Shows a Whole page component to manage the empty state when filtering by a certain range of dates returns no data

List of changes proposed in this pull request

  • add a boolean 'isEmpty' field to StatisticsParsedResponse model to immediately signal there's no significant response data
  • change Statistics.page to show the whole page component if isEmpty is true
  • change the text showed as description when filtering by dates returns an empty result

How to test

  • Go to Sender Dashboard, filter using a narrow dates range to force an empty data response and verify the behaviour is as described by the linked task

chore: rename StatisticsParsedResponse 'empty' field to 'isEmpty' to explicit its boolean type
@mflauti mflauti changed the title feat/PN-11564 -Whole page component to manage the empty state feat/PN-11564 - Whole page component to manage the empty state Jun 12, 2024
@mflauti mflauti marked this pull request as ready for review June 12, 2024 16:24
@AndreaCimini90 AndreaCimini90 self-assigned this Jun 13, 2024
AndreaCimini90
AndreaCimini90 previously approved these changes Jun 17, 2024
@AndreaCimini90 AndreaCimini90 marked this pull request as draft June 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants