Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/PN-11563 - Add 'download jpeg' button to sender dashboard #1259

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

mflauti
Copy link
Contributor

@mflauti mflauti commented Jun 17, 2024

Short description

This code adds the Screenshot module to utility folder (pn-commons) to allow jpeg image generation starting from an html node.

List of changes proposed in this pull request

  • adds Screenshot module under pn-commons 'utility' folder
  • changes Statistics.page adding a global 'export jpeg' button
  • removes the download icon from every statistics component
  • changes formatDate method in common date.utility to specify a custom separator

How to test

  • Go to sender dashboard and verify the 'download jpeg' button is visible and there's no download icon on statistics components
  • Click on the 'download jpeg' button and verify a jpeg screenshot of every statistics component is generated and available to download.

… download it

refactor: add 'Export to JPEG' button to Statistics.page
refactor: remove download icon from statistics components
refactor: change date.utility 'formatDate' to accept a custom separator for the formatted dates
@mflauti mflauti changed the title feat/PN-11563 - Add 'download jpeg' button on sender dashboard feat/PN-11563 - Add 'download jpeg' button to sender dashboard Jun 18, 2024
@AndreaCimini90 AndreaCimini90 self-assigned this Jun 18, 2024
@mflauti mflauti marked this pull request as ready for review June 18, 2024 09:34
@mflauti mflauti marked this pull request as draft June 18, 2024 09:43
@AndreaCimini90 AndreaCimini90 marked this pull request as ready for review July 1, 2024 15:02
@AndreaCimini90 AndreaCimini90 merged commit 89b0508 into develop Jul 3, 2024
15 checks passed
@AndreaCimini90 AndreaCimini90 deleted the feat/PN-11563 branch July 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants