Error when trying to open zendesk ticket with popup blocked - Fix/pn 10724 #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (e) { | ||
| dispatch( | ||
| appStateActions.addError({ | ||
| title: t('messages.generic-title'), |
There was a problem hiding this comment.
@AndreaCimini90 which could be the reasons why the opening of zendesk ticket gives error?
Like, if it's specific to popup configurations, it is better to return to the user a better message
There was a problem hiding this comment.
@ZorbaDimatteo i'm waiting for a feedback from UI/UX about the message. The reasons why the submission to the form gives error, can include for example server errors or network issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
When user browser has popups blocked, the POST of the zendesk form goes in error. So we have decided to open the form in the same page and show an error message when the POST going in error.
List of changes proposed in this pull request
How to test
Disable popup in your browser -> login with pf -> click on assistance link -> fill the form and click on confirm -> check that the zendesk form is opened without errors