Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [RTD-954] add min and max validation on amount input field #297

Merged
merged 2 commits into from Nov 24, 2022

Conversation

and-mora
Copy link
Contributor

@and-mora and-mora commented Nov 24, 2022

Description

This PR proposes to add a validation on the field amount of the input transaction file. Min value admitted is 0 and max value is 10^11 -1 (99.999.999.999).

List of Changes

  • add the field validation and related unit tests

Motivation and Context

The amount field needs to have a maximum and minimum value admitted.

How Has This Been Tested?

  • Unit Test Suite
  • Integration Test Suite
  • Load Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore change (non-breaking change which doesn't provide a direct value to users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@and-mora and-mora changed the title feat: [RTD-954] add max validation on amount input field feat: [RTD-954] add min and max validation on amount input field Nov 24, 2022
@and-mora and-mora marked this pull request as ready for review November 24, 2022 11:56
@and-mora and-mora merged commit 886590d into develop Nov 24, 2022
@and-mora and-mora deleted the RTD-954-set-validation-on-amount-field branch November 24, 2022 14:25
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants