Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [RTD-954] add min and max validation on amount input field #297

Merged
merged 2 commits into from
Nov 24, 2022
Merged

feat: [RTD-954] add min and max validation on amount input field #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f240f3a
[RTD-954] add max validation on amount input field
and-mora Nov 24, 2022
390290f
[RTD-954] add min validation on amount input field
and-mora Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ch/src/main/java/it/gov/pagopa/rtd/transaction_filter/batch/model/InboundTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package it.gov.pagopa.rtd.transaction_filter.batch.model;

import javax.validation.constraints.Max;
import javax.validation.constraints.Min;
import lombok.*;

import javax.validation.constraints.NotBlank;
Expand Down Expand Up @@ -84,8 +86,11 @@

/**
* Transaction amount
* max value: 999.999.999,99€
*/
@NotNull
@Min(value = 0)
@Max(value = 99999999999L)
Long amount;

/**
Expand Down
13 changes: 12 additions & 1 deletion ...transaction_filter/batch/step/processor/InboundTransactionItemProcessorValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ void processTransactionWithValidCorrelationId(String correlationId) {
}

@ParameterizedTest
@ValueSource(longs = {1000, 200000})
@ValueSource(longs = {0, 1000, 200000, Integer.MAX_VALUE + 1L, 3000000000L, 99999999999L})
void processTransactionWithValidAmount(Long amount) {
BDDMockito.doReturn(true).when(storeServiceMock).hasHpan(FAKE_ENROLLED_PAN);
BDDMockito.doReturn(FAKE_SALT).when(storeServiceMock).getSalt();
Expand All @@ -241,6 +241,17 @@ void processTransactionWithValidAmount(Long amount) {
Assertions.assertEquals(amount, outbound.getAmount());
}

@ParameterizedTest
@ValueSource(longs = {-100L, 100000000000L})
void processTransactionWithInvalidAmount(Long amount) {
BDDMockito.doReturn(true).when(storeServiceMock).hasHpan(FAKE_ENROLLED_PAN);
BDDMockito.doReturn(FAKE_SALT).when(storeServiceMock).getSalt();
InboundTransaction transaction = fakeInboundTransaction();
transaction.setAmount(amount);
InboundTransactionItemProcessor processor = new InboundTransactionItemProcessor(storeServiceMock, false);
Assertions.assertThrows(ConstraintViolationException.class, () -> processor.process(transaction));
}

@ParameterizedTest
@ValueSource(strings = {"1234", "412", "15", ""})
void processTransactionWithInvalidAmountCurrencyThrowsException(String amountCurrency) {
Expand Down