fix: [RTD-1669] fix conditional flow after ack fails #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and-mora
requested review from
GiovanniMancini,
TommasoLencioni,
petretiandrea and
lucaconsalvi
as code owners
TommasoLencioni
approved these changes
May 11, 2023
|
Kudos, SonarCloud Quality Gate passed! |
and-mora
added a commit
that referenced
this pull request
May 12, 2023
* fix: [RTD-540] use nio library to create temp file (#356) * fix: [RTD-540] solve bomb zip security hotspot (#357) * [RTD-540] solve zip bomb by checking uncompressed file size * [RTD-540] solve zip bomb by checking uncompressed file size * [RTD-540] solve zip slip vulnerability * [RTD-540] add compression ratio check * [RTD-540] typo * [RTD-540] utilize copyLarge of apache common * [RTD-540] remove common io library usage * [RTD-540] reduce cognitive complexity * [RTD-540] remove codeql action * fix: [RTD-1655] reduce log severity on ack confirm failure (#358) * fix: [RTD-540] use nio library to create temp file (#356) * fix: [RTD-540] solve bomb zip security hotspot (#357) * [RTD-540] solve zip bomb by checking uncompressed file size * [RTD-540] solve zip bomb by checking uncompressed file size * [RTD-540] solve zip slip vulnerability * [RTD-540] add compression ratio check * [RTD-540] typo * [RTD-540] utilize copyLarge of apache common * [RTD-540] remove common io library usage * [RTD-540] reduce cognitive complexity * [RTD-540] remove codeql action * [RTD-1655] reduce log severity on ack confirm failure * [RTD-1655] bump pom version to 2.0.3 * fix: [RTD-1669] fix conditional flow after ack list retrieve fails (#360) * [RTD-1669] fix conditional flow on ade-ack step failure * [RTD-1669] improve failure handling and logging
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes to fix a bug in the conditional flow after the ade-ack download step. Atm when the ade-ack-list step fails the filemanagement step is skipped and the job ends. Desiderata is: when ade-ack-list step fails then the filemanagement step is executed.
List of Changes
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: