Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Promotion to master #359

Merged
merged 5 commits into from
May 12, 2023
Merged

fix: Promotion to master #359

merged 5 commits into from
May 12, 2023

Conversation

and-mora
Copy link
Contributor

@and-mora and-mora commented May 11, 2023

Description

This PR proposes to promote to master

List of Changes

  • fix security hotspots
  • reduce log severity on ack confirm failure
  • fix bug in conditional flow after senderAdeAck fails
  • improve logging and exception handling
  • bump pom version to 2.0.3
  • update acceptance tests

Motivation and Context

How Has This Been Tested?

  • Unit Test Suite
  • Integration Test Suite
  • Load Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore change (non-breaking change which doesn't provide a direct value to users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

* [RTD-540] solve zip bomb by checking uncompressed file size

* [RTD-540] solve zip bomb by checking uncompressed file size

* [RTD-540] solve zip slip vulnerability

* [RTD-540] add compression ratio check

* [RTD-540] typo

* [RTD-540] utilize copyLarge of apache common

* [RTD-540] remove common io library usage

* [RTD-540] reduce cognitive complexity

* [RTD-540] remove codeql action
* fix: [RTD-540] use nio library to create temp file (#356)

* fix: [RTD-540] solve bomb zip security hotspot (#357)

* [RTD-540] solve zip bomb by checking uncompressed file size

* [RTD-540] solve zip bomb by checking uncompressed file size

* [RTD-540] solve zip slip vulnerability

* [RTD-540] add compression ratio check

* [RTD-540] typo

* [RTD-540] utilize copyLarge of apache common

* [RTD-540] remove common io library usage

* [RTD-540] reduce cognitive complexity

* [RTD-540] remove codeql action

* [RTD-1655] reduce log severity on ack confirm failure

* [RTD-1655] bump pom version to 2.0.3
)

* [RTD-1669] fix conditional flow on ade-ack step failure
* [RTD-1669] improve failure handling and logging
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@petretiandrea petretiandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪

Copy link
Contributor

@lucaconsalvi lucaconsalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !! 🙏

@and-mora and-mora merged commit 9b9940a into master May 12, 2023
8 of 10 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants