refactor: structure of project refactored based on standards #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
approved these changes
May 23, 2024
b00f
approved these changes
May 23, 2024
| @@ -5,13 +5,14 @@ import ( | |||
| "os" | |||
| "strings" | |||
|
|
|||
| "github.com/pagu-project/Pagu/internal/engine" | |||
There was a problem hiding this comment.
I suggest make Pagu lowercase here: github.com/pagu-project/pagu
There was a problem hiding this comment.
Need to change the repo name to github.com/pagu-project/pagu on github and actually I have no access to do that
| "github.com/pagu-project/Pagu/internal/engine" | ||
| "github.com/pagu-project/Pagu/internal/engine/command" | ||
| "github.com/pagu-project/Pagu/pkg/log" | ||
|
|
||
| "github.com/pactus-project/pactus/crypto" | ||
| pagu "github.com/pagu-project/Pagu" | ||
| pCmd "github.com/pagu-project/Pagu/cmd" |
There was a problem hiding this comment.
Because we have cmd *cobra.Command as the parameter of the run function. I know this naming is not good but let's fix it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The project structure refactored based on this repo
Also, sub-commands have been separated into independent files
Related Issue