Upgrade precinct to version 8 #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pahen Could you please look at this one? 🙏 |
|
@realityking , This approach didn't seem to work for me because of the different version of precinct used by dependency-tree. I opened a PR in dependency-tree to upgrade precinct there, and it is now merged and released. We can now upgrade both packages as shown in #284 . This approach did solve the issue of dynamic imports for me. I'm currently using the patched version off my github branch. |
|
This is fixed in madge v5.0.0 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only breaking change is a difference in CLI output, which doesn't impact
madge: dependents/node-precinct@v7.1.0...v8.1.0It does however upgrade
detective-typescriptto version 7 so it'll deduplicate with the one that's a direct dependency frommadge.