Skip to content
This repository has been archived by the owner on Apr 22, 2019. It is now read-only.

Dupe bug in EE 522 #1057

Closed
tahg opened this issue May 24, 2016 · 5 comments
Closed

Dupe bug in EE 522 #1057

tahg opened this issue May 24, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@tahg
Copy link

tahg commented May 24, 2016

The latest, and possibly earlier versions of EE has an issue with removing items and EMC from the table. See here:
Video of bug

@pahimar pahimar added this to the 0.3.* milestone May 25, 2016
@pahimar pahimar self-assigned this May 25, 2016
@pahimar
Copy link
Owner

pahimar commented May 25, 2016

Pretty sure this is a rounding issue, and likely also what I'm seeing in #1054

Will be starting my troubleshooting here tomorrow: https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/api/exchange/EnergyValue.java#L149

@tahg
Copy link
Author

tahg commented May 25, 2016

If this helps at all, the issue only seems to happen when merging it an existing stack, (either the first suitable stack it finds is partly full, or clicking into your hand with some items already). This generally causes the Table not to remove any EMC. If you're shift clicking and it finds an empty slot, or you're removing a single item by hand from the table, it works properly.

@pahimar
Copy link
Owner

pahimar commented May 27, 2016

This does not appear to be related at all to a rounding error. What I thought was a rounding error was actually a fault in the WrappedStack comparator causing the items I was testing this issue with to have bad values.

79bf272

@pahimar
Copy link
Owner

pahimar commented May 30, 2016

Please try again with 0.3.0.540, I think there still may be a bug in there but it might be a bit better now

@pahimar
Copy link
Owner

pahimar commented May 31, 2016

I believe this is now resolved in 0.3.0.542

@pahimar pahimar closed this as completed May 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants