add implementation for rand traits on dimensioned types #45
Conversation
There was a problem hiding this comment.
Cool! It's a shame rand_core doesn't have the appropriate traits, as then this could be added without the feature flag.
Looks like there are a couple conflicts with the ClapMe PR that need to be resolved, and if you don't mind, could you add this to the CHANGELOG.md? (I should really add a contributing guide that requests this).
| /// This is an internal implementation detail that the rand | ||
| /// crate requires us to expose. Sorry about that. | ||
| #[derive(Clone, Copy, Debug)] | ||
| pub struct MyUniformSampler<V: SampleUniform, U> { |
There was a problem hiding this comment.
Since this is an implementation detail, let's add #[doc(hidden)]
src/build/mod.rs
Outdated
| " | ||
| }}" | ||
| )?; | ||
| // done with serde test |
There was a problem hiding this comment.
This should probably read done with rand test
|
Also, @droundy, by a request, I would like to bump the version and deploy dimensioned to crates today (as I am unlikely to have time this week). If you can get this mergeable sometime today, it could join that deploy. Otherwise, we can also bump the version again. |
I also added a tests-feature-combos.sh script in tests/ which I used to find out where I broke other features. Probably this should be used in travis (it only took 3 minutes to run on my machine), but not in a merge commit.
|
Hi @paholg, I've done the merge, and also added a little script to test feature combinations. |
This will allow users to directly create random values with dimensions, which seems like a significant win.