-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn’t work with library symbol overrides #8
Comments
Thanks for reporting this. I haven't tested with layers from external libraries, so you may be right that it's a bug in Can you tell me one thing though - have you used regular "Sketch Data" on a layer imported from a Library? And does that work? So, if you do exactly the same thing you tried with Thanks! |
Yes, I tested this.
|
Ok great. Hopefully they expose the ability to set this in the API. I will take a look this weekend. If it's possible to fix, it should be done in a few days. |
Hi @timohofmeijer - a quick update. I did some debugging this weekend and recreated your issue. Two things I learned:
So I can likely get I'll keep going on this next weekend. |
Hi Paul, grateful for your efforts! One could of course rename layers in a self managed library. With an external library (e.g. iOS) this would require a fork and is likely not desirable. I personally would prefer applying data manually even though I manage the library myself. I could fork and have a look at the code this weekend, if you could let me know if you are not already on this, so we don't spend duplicate time : ) |
@timohofmeijer Just pushed a version live for testing. You should now be able to override the text in a library layer using Manual mode. Automatic mode works too, but it sets the layer name on the parent. This is the only editable layer name and actually happens automatically. However, since the layer that gets the new content is only the layer that is selected, it updates the correct layer with the text. I'll have to investigate more, but let me know what you think |
Hi @timohofmeijer I broke Library symbol overrides in a previous release, sorry about that. It is now fixed with 0.7.0. If you're still using it, I'd love to hear if it worked for you. Thanks! |
To reproduce, add any library symbol with a text override to a new document and try to apply faker data to it.
Tested this in Sketch 54.
The text was updated successfully, but these errors were encountered: