Support Spring #123
Merged
Support Spring #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
QubitPi
reviewed
May 9, 2024
QubitPi
requested changes
May 11, 2024
There was a problem hiding this comment.
If mysql connector 8.x is used, docker compose should be updated to use 8.0 too
QubitPi
requested changes
May 12, 2024
QubitPi
requested changes
May 12, 2024
QubitPi
requested changes
May 12, 2024
QubitPi
requested changes
May 12, 2024
QubitPi
requested changes
May 12, 2024
QubitPi
requested changes
May 12, 2024
QubitPi
requested changes
May 12, 2024
Doom9527
force-pushed
the
issue-116
branch
2 times, most recently
from
3e132dc
to
c14287f
Compare
QubitPi
requested changes
May 14, 2024
QubitPi
requested changes
May 14, 2024
QubitPi
requested changes
May 14, 2024
src/test/groovy/com/paiondata/astraios/config/SpringbootJarITSpec.groovy
Outdated
Show resolved
Hide resolved
QubitPi
requested changes
May 14, 2024
src/test/groovy/com/paiondata/astraios/config/DockerComposeITSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/com/paiondata/astraios/config/AbstractITSpec.groovy
Outdated
Show resolved
Hide resolved
QubitPi
requested changes
May 14, 2024
src/main/java/com/paiondata/astraios/keyConfig/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
QubitPi
requested changes
May 14, 2024
src/main/java/com/paiondata/astraios/keyConfig/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/keyConfig/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/keyConfig/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/keyConfig/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/keyConfig/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/keyConfig/ApplicationConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/keyConfig/ApplicationConfig.java
Outdated
Show resolved
Hide resolved
QubitPi
requested changes
May 14, 2024
src/main/java/com/paiondata/astraios/config/SecurityConfigProperties.java
Show resolved
Hide resolved
QubitPi
requested changes
May 14, 2024
Doom9527
force-pushed
the
issue-116
branch
2 times, most recently
from
ee000be
to
b3080d4
Compare
QubitPi
requested changes
May 16, 2024
QubitPi
requested changes
May 16, 2024
src/main/java/com/paiondata/astraios/settings/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/paiondata/astraios/settings/JpaDatastoreConfig.java
Outdated
Show resolved
Hide resolved
QubitPi
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
elide.versionfrom 7.0.0-pr6 to 7.0.0 becauseElideSettingsconflicts within the last method undersrc/main/java/com/paiondata/astraios/config/ElideConfiguration.java.The version 7.0.0 is also officially used in Elide Springboot Example.I turn off checking the annotation requirements for the main method by changing
UncommentedMainvalue form error to warning incheckstyle.xmlbeacause even though I annotated it,it still reported an error.I don't think turning off the check will cause too many problems and it maybe the bug.Fix bug, In
src/test/groovy/com/paiondata/astraios/config/DockerComposeITSpec.groovy, I set the wait time to 10 minutes because it did not wait for docker to start before sending the request.I overide
stop()method insrc/test/java/com/paiondata/astraios/config/KeepAliveMySQLContainer.javato keep the mysql container running for later test insrc/test/groovy/com/paiondata/astraios/config/AbstractITSpec.groovyCreate a static holder class
src/test/java/com/paiondata/astraios/config/TestContextHolder.javato save and retrieve the random port. Solved the problem that multiple tests preempt each other's ports.