Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements on StampChangelogAction #39

Merged
merged 9 commits into from Mar 11, 2019
Merged

improvements on StampChangelogAction #39

merged 9 commits into from Mar 11, 2019

Conversation

yjosephides
Copy link
Contributor

  • Stamps section identifier with version instead of git tag
  • Reverses order of tags in diff link for bitbucket links

In my case, version and git tags were in the following format:
[1.5.0.12.beta]: https://bitbucket.org/.../compare/v.1.5.0.12.beta..v.1.5.0.10.beta
[1.5.0.13.beta]: https://bitbucket.org/.../compare/v.1.5.0.13.beta..v.1.5.0.12.beta
[1.6.0.14.beta]: https://bitbucket.org/.../compare/v.1.6.0.14.beta..v.1.5.0.13.beta

When applying a stamp with version: 1.6.0.15.beta and git_tag: v.1.6.0.15.beta the changelog should look like:
[1.5.0.12.beta]: https://bitbucket.org/.../compare/v.1.5.0.12.beta..v.1.5.0.10.beta
[1.5.0.13.beta]: https://bitbucket.org/.../compare/v.1.5.0.13.beta..v.1.5.0.12.beta
[1.6.0.14.beta]: https://bitbucket.org/.../compare/v.1.6.0.14.beta..v.1.5.0.13.beta
[1.6.0.15.beta]: https://bitbucket.org/.../compare/v.1.6.0.15.beta..v.1.5.0.14.beta

- Stamps section identifier with version instead of git tag
- Reverses order of tags in diff link for bitbucket links
@pajapro pajapro self-assigned this Feb 26, 2019
@pajapro pajapro self-requested a review February 26, 2019 19:25
@pajapro pajapro assigned yjosephides and unassigned pajapro Feb 26, 2019
Copy link
Owner

@pajapro pajapro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution @sthwicked 2 things here:

  1. could you please rebase onto master, which should fix the failing build
  2. I would appreciate unit tests for your changes - both to ensure it works as you expect as well as document the functionality

@pajapro pajapro merged commit 55c4b34 into pajapro:master Mar 11, 2019
@pajapro
Copy link
Owner

pajapro commented Mar 11, 2019

Thanks for contribution @sthwicked - these changes are released now in version 0.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants