Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cheer Alert module #1158

Merged
merged 23 commits into from
Feb 7, 2021
Merged

Conversation

ALazyMeme
Copy link
Member

@ALazyMeme ALazyMeme commented Feb 6, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable

Added a cheer alert module, the amounts are pre-defined to twitch's default bit amounts you can purchase. Everything above 1 bit I've left intentionally blank (I'm not creative enough to think up of several different messages, and if I'm inputting the same message everytime; then it's pointless).

@ALazyMeme
Copy link
Member Author

This is mostly done, but I'm running into a fairly major issue. I don't believe the on_pubmsg has support for the tags argument? Maybe I'm wrong:

 [2021-02-06 14:27:23,945] [ERROR  ] Unhandled exception from <bound method CheerAlertModule.on_pubmsg of <pajbot.modules.chat_alerts.cheeralert.CheerAlertModule object at 0x7f80cc038760>> in on_pubmsg
 Traceback (most recent call last):
   File "/opt/pajbot/pajbot/managers/handler.py", line 116, in trigger
     res = handler(*args, **kwargs)
 TypeError: on_pubmsg() missing 1 required positional argument: 'tags'

@ALazyMeme
Copy link
Member Author

Ok, I've fixed the tags issue, running into a new issue where points are not given and the bot does not announce the points

@ALazyMeme
Copy link
Member Author

SO the issue was fixed by changing the key names not not start with a number

@ALazyMeme
Copy link
Member Author

Will push a changelog commit once #1157 is merged

@ALazyMeme ALazyMeme marked this pull request as ready for review February 6, 2021 15:17
pajbot/modules/chat_alerts/cheeralert.py Outdated Show resolved Hide resolved
pajbot/modules/chat_alerts/cheeralert.py Outdated Show resolved Hide resolved
pajbot/modules/chat_alerts/cheeralert.py Outdated Show resolved Hide resolved
pajbot/modules/chat_alerts/cheeralert.py Outdated Show resolved Hide resolved
pajbot/bot.py Show resolved Hide resolved
@pajlada pajlada changed the title Add bit alert support Add Cheer Alert module Feb 7, 2021
@pajlada pajlada merged commit 7a9a82f into pajbot:master Feb 7, 2021
@ALazyMeme ALazyMeme deleted the add-bit-alert-support branch February 7, 2021 13:50
@ALazyMeme ALazyMeme restored the add-bit-alert-support branch February 7, 2021 13:50
@ALazyMeme ALazyMeme deleted the add-bit-alert-support branch February 7, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants