Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full pleblist removal #1814

Merged
merged 25 commits into from
Apr 9, 2022
Merged

Full pleblist removal #1814

merged 25 commits into from
Apr 9, 2022

Conversation

ALazyMeme
Copy link
Member

@ALazyMeme ALazyMeme commented Apr 4, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

Full pleblist removal excluding the db-related code.

@ALazyMeme ALazyMeme requested a review from pajlada April 4, 2022 12:19
@ALazyMeme ALazyMeme changed the title Chore/full pleblist removal Full pleblist removal Apr 4, 2022
scripts/migrate-mysql-to-postgresql.py Outdated Show resolved Hide resolved
scripts/restore-pleblist-songs.sql Outdated Show resolved Hide resolved
@ALazyMeme ALazyMeme requested a review from RAnders00 April 5, 2022 11:20
@ALazyMeme
Copy link
Member Author

ALazyMeme commented Apr 5, 2022

I can see that it might be worth removing the httplib2 and types-httplib2 dependencies. Any suggestions on how to modify the code to remove it?

def init(developer_key):
if PleblistManager.youtube is None:
import apiclient
from apiclient.discovery import build
def build_request(_, *args, **kwargs):
import httplib2
new_http = httplib2.Http()
return apiclient.http.HttpRequest(new_http, *args, **kwargs)
PleblistManager.youtube = build("youtube", "v3", developerKey=developer_key, requestBuilder=build_request)

@RAnders00 RAnders00 dismissed their stale review April 7, 2022 11:59

all issues adressed

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did minimal testing, works as expected 👌 if you can give it a small amount of testing @ALazyMeme then merge it in that's fine by me

@ALazyMeme ALazyMeme enabled auto-merge (squash) April 9, 2022 03:17
@ALazyMeme
Copy link
Member Author

End of an era FeelsBaddestMan

@ALazyMeme ALazyMeme removed the request for review from RAnders00 April 9, 2022 03:22
@ALazyMeme ALazyMeme merged commit bca9e8f into master Apr 9, 2022
@ALazyMeme ALazyMeme deleted the chore/full-pleblist-removal branch April 9, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants