Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template strings where possible in javascript code #1839

Merged
merged 5 commits into from
Apr 16, 2022
Merged

Use template strings where possible in javascript code #1839

merged 5 commits into from
Apr 16, 2022

Conversation

ALazyMeme
Copy link
Member

@ALazyMeme ALazyMeme commented Apr 15, 2022 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

There shouldn't be any change in function to the bot, just code cleanup.

pajlada
pajlada reviewed Apr 16, 2022
View reviewed changes
static/scripts/commands.js Outdated Show resolved Hide resolved
@pajlada pajlada changed the title Migrate js scripts to template strings Use template strings where possible in javascript code Apr 16, 2022
@pajlada pajlada enabled auto-merge (squash) April 16, 2022 09:44
@pajlada pajlada merged commit 53844ce into master Apr 16, 2022
@pajlada pajlada deleted the chore/migrate-js-scripts-to-template-strings branch April 16, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ALazyMeme @pajlada