Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update underscore script to 1.13.2 #1841

Merged
merged 7 commits into from
Apr 30, 2022

Conversation

ALazyMeme
Copy link
Member

@ALazyMeme ALazyMeme commented Apr 15, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

@ALazyMeme ALazyMeme marked this pull request as ready for review April 25, 2022 12:16
@ALazyMeme
Copy link
Member Author

I have no idea how to effectively test this, since underscore.js doesn't seem to have just 1 feature to it. If anyone has any suggestions, I'd be happy to hear.

@RAnders00
Copy link
Contributor

You could take a look at the changelog for underscorejs and look at the breaking changes for v1->v2 and v2->v3

@ALazyMeme
Copy link
Member Author

Lots of fixes and additions, I don't see any breaking changes: https://underscorejs.org/#changelog

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use the _.escape function which doesn't seem to have had any changes.

@ALazyMeme ALazyMeme enabled auto-merge (squash) April 30, 2022 11:10
@ALazyMeme ALazyMeme merged commit b6a4b93 into master Apr 30, 2022
@ALazyMeme ALazyMeme deleted the chore/update-underscore-script-to-1.13.2 branch April 30, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants