Added the announcement message type #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
requested changes
Apr 23, 2022
There was a problem hiding this comment.
Feature looks good to me, happy to add it. I think we should call it announce instead though, if that's something you can do just poke me when it's done and I'll review&merge this in. If not, let me know and I'll make those changes on your branch 👍 Thank you!
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
pajlada
reviewed
Apr 24, 2022
pajlada
requested changes
Apr 24, 2022
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
ALazyMeme
requested changes
Apr 25, 2022
Co-authored-by: ALazyMeme <12804673+ALazyMeme@users.noreply.github.com>
ALazyMeme
requested changes
Apr 28, 2022
Co-authored-by: ALazyMeme <12804673+ALazyMeme@users.noreply.github.com>
Co-authored-by: ALazyMeme <12804673+ALazyMeme@users.noreply.github.com>
pajlada
approved these changes
Apr 30, 2022
ALazyMeme
changed the title
pajlada
added a commit
that referenced
this pull request
Jun 4, 2022
This was missing since the `announce` message type was added in #1847
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicable