Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate delete_or_timeout function to bot class #1872

Merged
merged 12 commits into from
Apr 30, 2022

Conversation

ALazyMeme
Copy link
Member

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

@ALazyMeme ALazyMeme changed the title Migrate delete or timeout function to bot class Migrate delete_or_timeout function to bot class Apr 25, 2022
pajbot/bot.py Outdated Show resolved Hide resolved
pajbot/bot.py Outdated Show resolved Hide resolved
pajbot/bot.py Outdated Show resolved Hide resolved
@ALazyMeme
Copy link
Member Author

Will test once initial code is approved.

Copy link
Contributor

@RAnders00 RAnders00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking like this

pajbot/bot.py Outdated Show resolved Hide resolved
pajbot/bot.py Outdated Show resolved Hide resolved
ALazyMeme and others added 2 commits April 26, 2022 07:03
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
@RAnders00
Copy link
Contributor

RAnders00 commented Apr 26, 2022

I‘d like to get @pajlada‘s opinion on this, I‘m not a super huge fan but it‘s alright

@ALazyMeme ALazyMeme requested a review from pajlada April 30, 2022 09:45
@pajlada pajlada enabled auto-merge (squash) April 30, 2022 09:59
@pajlada pajlada merged commit f5cd555 into master Apr 30, 2022
@pajlada pajlada deleted the chore/migrate-`delete_or_timeout`-function-to-bot branch April 30, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants