-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate delete_or_timeout
function to bot class
#1872
Merged
pajlada
merged 12 commits into
master
from
chore/migrate-`delete_or_timeout`-function-to-bot
Apr 30, 2022
Merged
Migrate delete_or_timeout
function to bot class
#1872
pajlada
merged 12 commits into
master
from
chore/migrate-`delete_or_timeout`-function-to-bot
Apr 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALazyMeme
changed the title
Migrate
Migrate Apr 25, 2022
delete or timeout
function to bot classdelete_or_timeout
function to bot class
RAnders00
requested changes
Apr 25, 2022
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
Will test once initial code is approved. |
RAnders00
previously requested changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking like this
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
I‘d like to get @pajlada‘s opinion on this, I‘m not a super huge fan but it‘s alright |
…te_or_timeout`-function-to-bot
pajlada
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicable