Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web command list #1893

Merged
merged 4 commits into from
Apr 30, 2022
Merged

Fix web command list #1893

merged 4 commits into from
Apr 30, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 30, 2022

  • Use rjsmin instead of jsmin
  • Add changelog entry

Fixes #1891

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

We can now also minify the playsound admin js

`jsmin` messed up template strings (e.g. `\`foo bar\`` turned into `\`foobar\``)
@pajlada pajlada requested a review from ALazyMeme April 30, 2022 10:43
@ALazyMeme ALazyMeme enabled auto-merge (squash) April 30, 2022 10:52
@ALazyMeme ALazyMeme merged commit 2a87ae6 into master Apr 30, 2022
@ALazyMeme ALazyMeme deleted the chore/fixjsmin branch April 30, 2022 11:06
@RAnders00
Copy link
Contributor

@pajlada Is the behaviour broken in the last release? Or was pajbot never released with the broken behaviour?
(Just asking because in the latter case a changelog entry shouldn‘t be added.)

@pajlada
Copy link
Member Author

pajlada commented May 1, 2022

the

It was never in a release, can amend it in the release pr

@RAnders00
Copy link
Contributor

the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on commands does nothing on commands page
3 participants