Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update animate stylesheet to 4.1.1 #1898

Merged
merged 14 commits into from
May 7, 2022
Merged

Update animate stylesheet to 4.1.1 #1898

merged 14 commits into from
May 7, 2022

Conversation

ALazyMeme
Copy link
Member

@ALazyMeme ALazyMeme commented May 1, 2022 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

Migration guide is here: https://animate.style/#migration

@ALazyMeme ALazyMeme changed the title Move animate dependency to dependencies folder Update animate stylesheet to 4.1.1 May 1, 2022
@ALazyMeme
Copy link
Member Author

Notes:

  • pulsebig doesn't seem to exist anymore? I couldn't find any entries as to what is the best alternative.
  • Nothing seemingly happens when emote combos finish? I couldn't see anything wrong with the code. Usually it's meant to bounce out.

@ALazyMeme ALazyMeme requested a review from pajlada May 2, 2022 12:56
@ALazyMeme
Copy link
Member Author

Seemingly I didn't realize that pulsebig was a custom class. The changes made seem to fix that issue, but the second issue remains.

@ALazyMeme
Copy link
Member Author

The second issue is seemingly non-existent. It all seems to work now. Possible that it was fixed by my previous commit.

pajlada
pajlada approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected both in browser and in OBS 👍

@pajlada pajlada merged commit f81ddaa into master May 7, 2022
@pajlada pajlada deleted the chore/move-animate-dependency branch May 7, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ALazyMeme @pajlada