Migrate add_command function to send_message_to_user function
#1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
requested changes
May 7, 2022
There was a problem hiding this comment.
I'd prefer this sort of change was done one function at a time, with the function being moved out of dispatch.py - dispatch.py is not a concept that belongs in the current version of pajbot.
Overarching refactor/changes like this is also a lot more tedious to test because you have ~15-20 things to test every time - 10 small PRs > 1 big PR
ALazyMeme
force-pushed
the
chore/dispatch-module-message-migration
branch
from
78282b5
to
033c201
Compare
ALazyMeme
changed the title
send_message & send_message_to_user functionsadd_command function to send_message_to_user function
pajlada
approved these changes
May 8, 2022
|
Tested all branches, works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicable