Fix 7TV exception when streamer has no emotes #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fail atm, and can be run by setting the `PAJBOT_RUN_INTEGRATION_TESTS` environment variable to `1`
edge-cases include user who logged into 7tv but doesn't have an emote set, or user who logged into 7tv, created an emote set, but didn't add any emotes
…hen-streamer-has-no-emotes
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableFixes #2440
This is a lot of code to fix the mentioned issue, but it adds a stricter typing (my favourite python word) for the response we receive from the API.
We ignore extra fields that we don't declare in
model.py.This PR adds some 'integration tests' that can be run by setting the
PAJBOT_RUN_INTEGRATION_TESTSenvironment variable to1before running pytest, which allows you to test thefetch_*7TV functions