Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum duel amount setting to the duel module #2508

Merged
merged 6 commits into from Jul 29, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jul 29, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

Changes:

  • typing: get_duel_stats return bool
  • typing: pajbot.utils - define __all__ for explicit exports
  • typing: pajbot.managers.websocket typing for emit function
  • format: move each attribute to its own line for show_on_clr
  • Add minimum point amount to the duel module

I have decided not to change anything with the output, it's still hardcoded as whispers for error messages.
If we want to change this, it should be a new feature request.

Fixes #2400

@pajlada
Copy link
Member Author

pajlada commented Jul 29, 2023

Looks good to me!

image

@pajlada pajlada merged commit 749a117 into master Jul 29, 2023
10 checks passed
@pajlada pajlada deleted the feat/minimum-duel-amount branch July 29, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimum duel amount setting to duel module
1 participant