TMI Rates #878
Merged
TMI Rates #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ALazyMeme had the known bot idea |
RAnders00
requested changes
May 18, 2020
There was a problem hiding this comment.
There's a lot of changes I've requested. It might even be smarter to re-design the rate limiting in the bot altogether since as you can see it's not really flexible. In my opinion rate-limiting should be incorporated into bot.py (not one of the IRC classes) and all the logic should be "capsuled" into its own class.
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
|
Is there more i must fix/add? |
|
I think I want @pajlada to review this and work on it |
|
Sure. |
pajlada
requested changes
May 24, 2020
RAnders00
requested changes
May 24, 2020
RAnders00
requested changes
May 24, 2020
|
OkayChamp I'll make the entry |
|
i did these commits via the web interface WAYTOODANK |
pajlada
approved these changes
May 31, 2020
|
Is there more to change for this? |
RAnders00
approved these changes
Jun 7, 2020
RAnders00
reviewed
Jun 7, 2020
RAnders00
reviewed
Jun 7, 2020
RAnders00
reviewed
Jun 7, 2020
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
RAnders00
requested changes
Jun 7, 2020
RAnders00
approved these changes
Jun 7, 2020
pajlada
requested changes
Jun 7, 2020
pajlada
approved these changes
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableFixes #691