Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to unban when using the unpermaban command #887

Merged
merged 11 commits into from May 24, 2020

Conversation

ALazyMeme
Copy link
Member

@ALazyMeme ALazyMeme commented May 21, 2020

Simple option that allows users to be unbanned from chat upon use of the !unpermaban command. Fixes #739

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable

@Felanbird
Copy link
Contributor

Felanbird commented May 21, 2020

For consistency sakes, I believe the unban should be followed by a 1 second timeout so an unban reason can be added for mod logs. (viewercard)

@RAnders00
Copy link
Contributor

The thing @Felanbird wrote can be added separately

@ALazyMeme
Copy link
Member Author

@RAnders00 Do you want me to 100% add it separately? Or just commit it now?

@RAnders00
Copy link
Contributor

You can add it now if you want @ALazyMeme I was just saying it doesn't have to be added to this PR

@ALazyMeme ALazyMeme requested a review from RAnders00 May 23, 2020 12:07
Copy link
Contributor

@RAnders00 RAnders00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above 👍

pajbot/modules/basic/permaban.py Outdated Show resolved Hide resolved
Co-authored-by: Ruben Anders <ruben.anders@robotty.de>
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pajlada pajlada requested a review from RAnders00 May 24, 2020 09:13
@RAnders00 RAnders00 merged commit cf70321 into pajbot:master May 24, 2020
@ALazyMeme ALazyMeme deleted the add-option-to-unban-xd branch May 24, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpermaban command should unban the person from chat
4 participants