should post lgtm #10
Open
should post lgtm #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main.cpp
Outdated
|
|
||
| void anotherFunction() | ||
| { | ||
| auto test = new std::string; // :) |
There was a problem hiding this comment.
warning: 'auto test' can be declared as 'auto *test' [llvm-qualified-auto]
Suggested change
| auto test = new std::string; // :) | |
| auto *test = new std::string; // :) |
|
|
||
| void anotherFunction() | ||
| { | ||
| auto test = new std::string; // :) |
There was a problem hiding this comment.
warning: 'auto test' can be declared as 'auto *test' [llvm-qualified-auto]
Suggested change
| auto test = new std::string; // :) | |
| auto *test = new std::string; // :) |
| void anotherFunction() | ||
| { | ||
| auto test = new std::string; // :) | ||
| auto test2 = new std::string; // :) |
There was a problem hiding this comment.
warning: 'auto test2' can be declared as 'auto *test2' [llvm-qualified-auto]
Suggested change
| auto test2 = new std::string; // :) | |
| auto *test2 = new std::string; // :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.