Be smarter about marking & unmarking objects & npcs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
changed the title
*only* rely on varbits for which task is enabled, instead of using some saved config state. This removes the deprecated getCharacterName API
pajlada
force-pushed
the
fix/be-smarter-about-marking-and-unmarking-objects-and-npcs
branch
from
686fa0f
to
14bd863
Compare
stealing the object does not unmark the chest/dresser nor the stairs going upstairs, hint arrow is correctly unmarked
goal is wrong - I currently get `3440` XP from each artefact steal (100 steals)
|
|
Unmarking objects/ladders wasn't done in the original plugin either, so I'll note that down as a future improvement The XP goal has not been modified, so it was wrong before. I'll add that to a list of known issues to look into after this PR |
This was referenced Nov 29, 2023
This was referenced Feb 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a messy PR, refactoring & learning the project at the same time.
Some things have been changed just due to new APIs that are available.
Game object despawns aren't 100% reliable, so we make sure to reset & revalidate game objects on LOADING
This should be thoroughly tested before being merged in - I've done a bunch of runs myself but would happily accept more testing.
The expectation is that it should "just work".
The overlay should only show up when you're inside Port Pisc
NPCs highlights should only highlight the actual NPCs, and they shouldn't keep stacking onto each other
Stair & chest highlights should disappear when you TP away, get caught, or run away to turn in the artefact.
The hint arrows from other areas shouldn't be broken by the plugin. We basically make sure of this now by never setting the arrow in onGameTick - onGameTick is only used to revalidate objects when we hit loading lines or when we log in.
Known issues
We don't clear the hint arrow to a house when you walk out of pisc, which means the minimap arrow will keep pointing towards your house as long as you're still roughly nearby of pisc. North part of Hosidius will show the arrow with the minimap fully zoomed out. We could try to work around this, but the proper solution, imo, is to use our own hint arrow implementation. I'd like to do that in a separate PR