Circleflow snap #94
Merged
Circleflow snap #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HTML, a list item should be enclosed in <li>, not <ul>, which is for the whole list.
like ViewPagerIndicator's. It makes the active indicator jump to the next position instead of following the scroll offsets. I've also documentated it in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behaviour moves the 'active' indicator smoothly between pages. I think it looks a little neater in some cases if the circle just appears at the new page instead, so I've added that behaviour as an option. The "snap" name comes from Jake Wharton's ViewPagerIndicator, IIRC, but the code is unrelated. With 'snap' turned on, it looks like the inactive indicator changes to the active indicator instead of the active indicator moving along.
I've also updated the README with a description of the new option.