Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BPL_JVM_CLASS_ADJUSTMENT #602

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

modulo11
Copy link
Contributor

Summary

See paketo-buildpacks/libjvm#377.

If we agree on the description, I'll copy it to other JVM buildpacks. I kept it rather generic and not mention specific settings like metaspace. The default provided in the description is not 100% correct, but does not require any additional explanation (I hope).

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@modulo11 modulo11 requested a review from a team as a code owner April 12, 2024 11:00
@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:documentation A documentation update labels Apr 12, 2024
@dmikusa
Copy link
Contributor

dmikusa commented Apr 12, 2024

Looks great to me. Thanks for submitting this PR!

@dmikusa dmikusa merged commit b044148 into main Apr 12, 2024
7 checks passed
@dmikusa dmikusa deleted the document-class-adjustment branch April 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants