This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
builder toml rfc #36
Merged
builder toml rfc #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RFC to implement #27 Co-authored-by: Sophie Wigmore <swigmore@vmware.com>
|
@ForestEckhardt @sclevine @nebhale tagging you in this PR since I'm not able to add a reviewer |
|
@joshzarrabi Could you add a readable link to the initial post please? |
|
@joshzarrabi I only have feed back on readability. If you could move your alternative implementations into a different section that would make this more readable. Other than that I approve. |
Signed-off-by: Sophie Wigmore <swigmore@vmware.com>
ForestEckhardt
approved these changes
Sep 15, 2020
nebhale
suggested changes
Sep 15, 2020
sclevine
approved these changes
Sep 15, 2020
|
@nebhale I added the note about the lifecycle and builder, thanks for pointing that out :) |
nebhale
approved these changes
Sep 21, 2020
|
@joshzarrabi Approved over here. Merge and implement at will. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readable: https://github.com/joshzarrabi/builder/blob/builder-toml-rfc/rfcs/0002-buildpack-toml-versioning.md
Co-authored-by: Sophie Wigmore swigmore@vmware.com