Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for multiple certs via 1 binding #103

Merged
merged 1 commit into from
May 3, 2022
Merged

Added support for multiple certs via 1 binding #103

merged 1 commit into from
May 3, 2022

Conversation

pivotal-david-osullivan
Copy link
Contributor

Summary

Resolves #100
Files with multiple certs are written to separate files for correct hashing/symlinking

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan added type:enhancement A general enhancement semver:patch A change requiring a patch version bump labels Apr 29, 2022
@pivotal-david-osullivan pivotal-david-osullivan requested a review from a team as a code owner April 29, 2022 17:10
dmikusa
dmikusa requested changes Apr 29, 2022
View reviewed changes
cacerts/certs.go Outdated Show resolved Hide resolved
cacerts/certs_test.go Show resolved Hide resolved
cacerts/certs_test.go Outdated Show resolved Hide resolved
cacerts/testdata/SecureTrust_CA-corrupt.pem Show resolved Hide resolved
@dmikusa
Copy link
Contributor

dmikusa commented Apr 29, 2022

Delete the .DS_Store file as well and probably add that to the .gitignore

@pivotal-david-osullivan pivotal-david-osullivan merged commit bb91a28 into main May 3, 2022
@pivotal-david-osullivan pivotal-david-osullivan deleted the multi-certs branch May 3, 2022 13:51
@dmikusa dmikusa mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support a binding with multiple certs concatenated together
2 participants
@pivotal-david-osullivan @dmikusa