Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fixtures from buildpack.yml to env var configuration #172

Closed
3 tasks
fg-j opened this issue Apr 6, 2021 · 2 comments
Closed
3 tasks

Migrate fixtures from buildpack.yml to env var configuration #172

fg-j opened this issue Apr 6, 2021 · 2 comments

Comments

@fg-j
Copy link

fg-j commented Apr 6, 2021

What happened?

  • What were you attempting to do?
    I was looking around at the fixtures to explore ways of setting up dotnet apps.

  • What did you expect to happen?
    Given that buildpack.yml has been deprecated, I expected most of the fixtures to use a project.toml instead of a buildpack.yml.

  • What was the actual behavior? Please provide log output, if possible.
    But many of the fixtures still rely on a buildpack.yml because the work to move dotnet-execute away from buildpack.yml isn't finished yet.

Once paketo-buildpacks/dotnet-execute#159 is merged and complete, the fixtures here should be updated to remove the buildpack.yml

Build Configuration

  • What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
    using? Please include a version.

  • What buildpacks are you using? Please include versions.

  • What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?

  • Can you provide a sample app or relevant configuration (buildpack.yml,
    nginx.conf, etc.)?

Checklist

  • I have included log output.
  • The log output includes an error message.
  • I have included steps for reproduction.
@fg-j fg-j added the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Apr 6, 2021
@fg-j
Copy link
Author

fg-j commented Apr 6, 2021

Blocked by paketo-buildpacks/dotnet-execute#159

@fg-j fg-j removed the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Apr 16, 2021
@fg-j
Copy link
Author

fg-j commented Apr 16, 2021

Resolved by #176

@fg-j fg-j closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant