Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream dotnet publish output #293

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Stream dotnet publish output #293

merged 2 commits into from
Mar 4, 2022

Conversation

fg-j
Copy link

@fg-j fg-j commented Mar 3, 2022

Summary

Upgrades to packit v2 so that dotnet publish can stream logs using the scribe.LogEmitter writer.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@fg-j fg-j requested a review from a team as a code owner March 3, 2022 21:06
@fg-j fg-j added the semver:minor A change requiring a minor version bump label Mar 3, 2022
@sophiewigmore
Copy link
Member

confirmed that this works!

@sophiewigmore sophiewigmore merged commit 8eaf301 into main Mar 4, 2022
@sophiewigmore sophiewigmore deleted the upgrade-packit branch March 4, 2022 16:36
@sophiewigmore sophiewigmore mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/dotnet-core-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fg-j @sophiewigmore