Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard stack #331

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Support wildcard stack #331

merged 2 commits into from
Jul 13, 2022

Conversation

fg-j
Copy link

@fg-j fg-j commented Jul 8, 2022

Summary

Since this buildpack does not install any dependencies, I've set this to support the wildcard stack. Theoretically, any stack where the dotnet toolchain has been installed should be compatible with this buildpack.

I've added tests against the bionic and jammy builders. This requires a slight change to our integration script. See paketo-buildpacks/github-config#497

Use Cases

This facilitates us running the .NET Core buildpack on Jammy Jellyfish and other stacks in the future.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

test against bionic and jammy
@fg-j fg-j requested a review from a team as a code owner July 8, 2022 15:47
@fg-j fg-j added the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Jul 8, 2022
@fg-j fg-j added semver:minor A change requiring a minor version bump and removed status/blocked This issue has been triaged and resolving it is blocked on some other issue labels Jul 13, 2022
@ForestEckhardt ForestEckhardt merged commit 1970d92 into main Jul 13, 2022
@ForestEckhardt ForestEckhardt deleted the add-jammy branch July 13, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants