Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git buildpack into all order groups #558

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Add git buildpack into all order groups #558

merged 1 commit into from
Mar 8, 2022

Conversation

joshuatcasey
Copy link
Contributor

@joshuatcasey joshuatcasey commented Mar 1, 2022 •
edited
Loading

See issue for details

Resolves #557

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@joshuatcasey joshuatcasey added the semver:minor A change requiring a minor version bump label Mar 2, 2022
@joshuatcasey joshuatcasey changed the title Add git buildpack into the "go mod" order group Add git buildpack into all order groups Mar 2, 2022
@joshuatcasey
Copy link
Contributor Author

waiting on paketo-buildpacks/git#109

@joshuatcasey
Add optional git buildpack to all build orders
44fc3cd 
- it's put before any other buildpacks that should need it, such as "go mod"
@joshuatcasey joshuatcasey marked this pull request as ready for review March 8, 2022 00:04
@joshuatcasey joshuatcasey requested a review from a team as a code owner March 8, 2022 00:04
@joshuatcasey
Copy link
Contributor Author

Ready for review. It's no longer blocked on paketo-buildpacks/git#109, because paketo-buildpacks/git#111 is a workaround.

@ryanmoran ryanmoran merged commit 52fda81 into paketo-buildpacks:main Mar 8, 2022
@joshuatcasey joshuatcasey deleted the jtc/issue-557 branch March 8, 2022 17:13
@ForestEckhardt ForestEckhardt mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmoran ryanmoran ryanmoran approved these changes

@ForestEckhardt ForestEckhardt Awaiting requested review from ForestEckhardt ForestEckhardt is a code owner automatically assigned from paketo-buildpacks/go-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add git buildpack into the all order groups
2 participants
@joshuatcasey @ryanmoran