inspector: support flattened buildpacks #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With platforms introducing the ability to create flattened buildpackages[1], the idea of 1 layer = 1 buildpack is not always true anymore - a single layer can contain multiple buildpacks. This change adds to the inspector the ability to read buildpack metadata off flattened buildpacks. This fixes "jam summarize" when creating summary/release notes for flattened buildpacks. Previously it picked up the first buildpack.toml it could find in the layer, and assumed it to represent the buildpackage. [1]: buildpacks/pack#1691
arjun024
force-pushed
the
summarize-flatten
branch
2 times, most recently
from
fb3ba2a
to
668227e
Compare
sophiewigmore
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With platforms introducing the ability to create flattened buildpackages,
the idea of 1 layer = 1 buildpack is not always true anymore - a single layer can contain multiple buildpacks.
This change adds to the inspector the ability to read buildpack metadata off flattened buildpacks.
This fixes
jam summarizewhen creating summary/release notes for flattened buildpacks.Previously it picked up the first
buildpack.tomlit could find in the layer, and assumed it to represent the buildpackage.Checklist