Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the ability to add additional labels to stacks at build time #291

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Adds the ability to add additional labels to stacks at build time #291

merged 2 commits into from
Aug 17, 2023

Conversation

ForestEckhardt
Copy link
Contributor

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt ForestEckhardt requested a review from a team as a code owner August 16, 2023 19:32
robdimsdale
robdimsdale approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@robdimsdale robdimsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If we already had README documentation on using create-stack I would like to see a section added to that on adding custom labels.

But we don't have that yet, and I don't think we should block this PR on adding a whole set of documentation.

@robdimsdale robdimsdale added the semver:minor A change requiring a minor version bump label Aug 16, 2023
@robdimsdale
Copy link
Member

@ForestEckhardt I'm leaving this to you to merge in case there was anything else you wanted to do before merging.

@ForestEckhardt ForestEckhardt merged commit 1790df8 into main Aug 17, 2023
7 of 8 checks passed
@ForestEckhardt ForestEckhardt deleted the stack-image-labels branch August 17, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdimsdale robdimsdale robdimsdale approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ForestEckhardt @robdimsdale