-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support extensions in update_builder command #302
support extensions in update_builder command #302
Conversation
Signed-off-by: Michael Dawson <mdawson@devrus.com>
NOTE: All tests in CI passed so I guess this can be ignored :) I'm not sure why some of the changes in the test are needed, for example:
As I would have expected tests to fail without that change before, they do fail on my local runs without those changes so not quite sure what is going on. In my local Fedora environment there are some failures in the tests without of my changes. I'm assuming that is something environment related and that they won't show in the CI. These are the failures I see without any of my changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have one clarifying - and non-blocking - question in line
I've noticed that some |
Summary
Add handling of extension sections in builder toml files
Refs: #294
Use Cases
Supports update of toml files for builders that use extensions
Checklist