Add metrics support #519
Merged
Add metrics support #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, @mucsi96. Would you be willing to look into the unit test failures that we are seeing? |
|
Thx. I have fixed the build. |
|
Maybe it would make sense to add an integration test. Let me try to create one. |
That would bee appreciated! |
|
Sure. Integration test added :) |
ForestEckhardt
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BP_NGINX_STUB_STATUS_PORTvariable exposes a handful of NGINX Server metrics via thestub_statusmodule which provides basic status information on provided port.This comes handy for monitoring the server. For example using NGINX Prometheus Exporter