Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PORT=8080 as default env #535

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Use PORT=8080 as default env #535

merged 2 commits into from
Apr 28, 2023

Conversation

c0d1ngm0nk3y
Copy link
Contributor

fixes #430

Summary

The environment variable PORT is set to 8080, so that nginx starts by default on this port. If the user does not overwrite it.

Use Cases

Doing this would help to streamline the experience for users of the buildpack and reduce the number of environment variables required to run applications using this buildpack.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner April 14, 2023 15:11
@ForestEckhardt
Copy link
Contributor

Other than the above comment I think that this all looks good.

@ForestEckhardt ForestEckhardt added the semver:minor A change requiring a minor version bump label Apr 20, 2023
@ForestEckhardt ForestEckhardt enabled auto-merge (rebase) April 20, 2023 18:40
@ForestEckhardt
Copy link
Contributor

@c0d1ngm0nk3y If you could just rebase this branch then I think we would be good to go!

@ForestEckhardt
Copy link
Contributor

Bump @c0d1ngm0nk3y

@c0d1ngm0nk3y
Copy link
Contributor Author

Bump @c0d1ngm0nk3y

Sorry for the delay...

@ForestEckhardt ForestEckhardt merged commit f11e5a8 into paketo-buildpacks:main Apr 28, 2023
9 checks passed
@c0d1ngm0nk3y c0d1ngm0nk3y deleted the default_port branch April 28, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a default port if none is given
2 participants
@c0d1ngm0nk3y @ForestEckhardt