Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging #657

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Add debug logging #657

merged 2 commits into from
Apr 20, 2023

Conversation

c0d1ngm0nk3y
Copy link
Contributor

see #439

Summary

Added some debug logging for checking if the node layer can be reused from cache.

Use Cases

Some debug information about why the node layer was not reused might be interesting in certain situations.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner April 14, 2023 11:57
@c0d1ngm0nk3y
Copy link
Contributor Author

@sophiewigmore Did you had specific debug messages in mind that would be useful to have?

@sophiewigmore
Copy link
Member

@c0d1ngm0nk3y not particularly, we haven't standardized what types of things we want in our debug logs, or how they should be structured yet. I hope to do that at some point soon.

In general, the types of things that I linked to in the issue from the MRI buildpack are definitely along the lines I was thinking - information about the installation path, source URI, anything that would help a user out understanding how Node is being installed in the event something went wrong.

@linux-foundation-easycla
Copy link

CLA Not Signed

@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Apr 19, 2023
@thitch97 thitch97 merged commit aa190aa into main Apr 20, 2023
10 checks passed
@thitch97 thitch97 deleted the debug-logging branch April 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants