-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What do you think about doing npm install only? #11
Comments
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/168022847 The labels on this github issue will be updated when the story is started. |
So in this case, npm-cnb would just be used for compiling the frontend app, served by php backend? |
You are right. |
You should be able to specify the buildpacks you want to run as an argument to pack ie something like |
What'll happen in that case is that npm insstall will occur, and then later cnbs will provide app start commands. |
oh!! I understand. https://github.com/cloudfoundry/npm-cnb/blob/master/modules/modules.go#L97 Thank you for your answer! |
Glad I could help. Closing this issue
…On Fri, Aug 23, 2019 at 11:52 PM Kazuhiko Yamashita < ***@***.***> wrote:
oh!! I understand.
Since php-web-cnb and npm-cnb have the same value processes-> type = web
written in launch.toml, Thats' why When php-web-cnb is executed after
npm-cnb, npm start is overwritten and not executed
https://github.com/cloudfoundry/npm-cnb/blob/master/modules/modules.go#L97
https://github.com/cloudfoundry/php-web-cnb/blob/master/phpweb/contributor.go#L173
Thank you for your answer!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNGTYY75ACPQGHRWUFV7T3QGCWBHANCNFSM4IODDNYQ>
.
|
Hi team!
Thank you for your commitment to cnb.
by the way, I think, we not always need
npm start
.For example, I usualy make architecture with javascript for frontend and php for backend.
In this case use the web server is httpd or nginx, that's why I can't need
npm start
do you have a plan for npm only use
npm install
?Please confirm where necessary:
The text was updated successfully, but these errors were encountered: