Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection outputs log messages and should be silent #8

Closed
nebhale opened this issue Mar 29, 2019 · 2 comments
Closed

Detection outputs log messages and should be silent #8

nebhale opened this issue Mar 29, 2019 · 2 comments

Comments

@nebhale
Copy link
Member

nebhale commented Mar 29, 2019

Currently the npm buildpack prints output to stdout:

[detector] Trying group of 5...
[detector] ======== Output: NPM Buildpack ========
[detector] no "package.json" found at: /workspace/app/package.json
[detector] ======== Results ========
[detector] Node.js Buildpack: pass
[detector] Python Buildpack: pass
[detector] NPM Buildpack: fail
[detector] Node Function Buildpack: fail
[detector] Pivotal New Relic Buildpack: skip
[detector] Trying group of 4...
[detector] ======== Output: NPM Buildpack ========
[detector] no "package.json" found at: /workspace/app/package.json
[detector] ======== Results ========
[detector] Node.js Buildpack: pass
[detector] Python Buildpack: pass
[detector] NPM Buildpack: fail
[detector] Pivotal New Relic Buildpack: skip
[detector] Trying group of 1...
[detector] ======== Results ========
[detector] Command Function Buildpack: pass

This output is unnecessary and should only be output as debug logging.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/164991430

The labels on this github issue will be updated when the story is started.

@ndon55555
Copy link
Contributor

ndon55555 commented Aug 1, 2019

@nebhale Should be fixed on this commit now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants