Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test against jammy #218

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Integration test against jammy #218

merged 3 commits into from
Jul 27, 2022

Conversation

sophiewigmore
Copy link
Member

@sophiewigmore sophiewigmore commented Jul 25, 2022 •
edited
Loading

Summary

Test the stack against Jammy as part of paketo-buildpacks/nodejs#607

  • Remove the Bionic stack from the buildpack.toml in favour of just the wildcard stack

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore requested a review from a team as a code owner July 25, 2022 15:09
@sophiewigmore sophiewigmore self-assigned this Jul 25, 2022
@sophiewigmore sophiewigmore added the semver:patch A change requiring a patch version bump label Jul 25, 2022
@sophiewigmore
Copy link
Member Author

sophiewigmore commented Jul 25, 2022 •
edited
Loading

@paketo-buildpacks/nodejs-maintainers I guess the question is - is npm start something that actually needs to be tested against Jammy?

TisVictress
TisVictress previously approved these changes Jul 25, 2022
View reviewed changes
@TisVictress
Copy link
Contributor

@paketo-buildpacks/nodejs-maintainers I guess the question is - is npm start something that actually needs to be tested against Jammy?

I guess it's not required. But I like the idea of testing it for consistency if we are testing it against other stacks. I'm curious what other folks think.

@sophiewigmore
Copy link
Member Author

Testing against Jammy only per @ryanmoran comments on Node Start and Yarn Start.

@ryanmoran ryanmoran merged commit 5e36717 into main Jul 27, 2022
@ryanmoran ryanmoran deleted the jammy branch July 27, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmoran ryanmoran ryanmoran approved these changes

@TisVictress TisVictress TisVictress left review comments

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees

@sophiewigmore sophiewigmore

Labels
semver:patch A change requiring a patch version bump
Projects
Paketo Workstreams
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sophiewigmore @TisVictress @ryanmoran